Account Creation: Fix broken flow after signing up from the WordPress app #21751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0815f63.
4 tasks
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21751-67e1e15 | |
| Version | 23.4 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 67e1e15 | |
| App Center Build | WPiOS - One-Offs #7408 |
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21751-67e1e15 | |
| Version | 23.4 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 67e1e15 | |
| App Center Build | jetpack-installable-builds #6438 |
wargcm
approved these changes
Oct 13, 2023
mokagio
reviewed
Oct 20, 2023
Comment on lines
+117
to
+131
| if self?.isCancelled == true { | ||
| self?.state = .isFinished | ||
| DDLogInfo("🚩 Feature flags update operation canceled") | ||
| self?.completion(.failure(OperationError.operationCanceled)) | ||
| return | ||
| } | ||
| switch result { | ||
| case .success(let flags): | ||
| DDLogInfo("🚩 Successfully updated local feature flags: \(flags.dictionaryValue)") | ||
| self?.completion(.success(flags.dictionaryValue)) | ||
| case .failure(let error): | ||
| DDLogError("🚩 Unable to update Feature Flag Store: \(error.localizedDescription)") | ||
| self?.completion(.failure(error)) | ||
| } | ||
| self?.state = .isFinished |
There was a problem hiding this comment.
Unless I'm reading the code wrong, if self is nil, nothing will happen other than console logs.
Have you considered returning early with guard let self else { return }?
Comment on lines
+350
to
+358
| internal extension RemoteFeatureFlagStore { | ||
| func update(using remote: FeatureFlagRemote, waitOn test: XCTestCase) { | ||
| let exp = test.expectation(description: "Store finishes update") | ||
| update(using: remote) { | ||
| exp.fulfill() | ||
| } | ||
| test.wait(for: [exp], timeout: 1) | ||
| } | ||
| } |
There was a problem hiding this comment.
Interesting approach. For a moment I got worried because it looked like the test was no longer testing application code, but then I looked at the implementation and realized it called the app code internally.
This has definitely value because it DRYes what would otherwise be a lot of repeated async expectations.
I wonder if the DRY could be pushed even further. Most tests have a similar arrange structure:
let store = ...
let flags = ...
let remote = ...
store.update(using: remote, waitOn: self)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21746
Description
This PR fixes an issue where users signing up on the WordPress app land on the Reader while it should not be accessible.
The PR also introduces logic for synchronizing calls to fetch the remote feature flags, making sure that the latest network call is always respected regardless of when the response comes. This is to avoid the following scenario:
Testing Instructions
Regression Notes
Potential unintended areas of impact
Sign up flow on Jetpack
What I did to test those areas of impact (or what existing automated tests I relied on)
Tested manually
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.